From 072cd46809cfd902aaf6dac63e567ab88669f08b Mon Sep 17 00:00:00 2001 From: Lakhan Samani Date: Sun, 10 Oct 2021 01:15:47 +0530 Subject: [PATCH] fix: docker build version arg --- .github/workflows/release.yaml | 2 +- Dockerfile | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index cd6a939..c5209de 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -71,4 +71,4 @@ jobs: tags: ${{ steps.meta.outputs.tags }} labels: ${{ steps.meta.outputs.labels }} build-args: | - "VERSION=${VERSION}" + VERSION=${VERSION} diff --git a/Dockerfile b/Dockerfile index 430f6fc..0b695b6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -3,13 +3,13 @@ WORKDIR /app COPY server server COPY Makefile . -ARG VERSION -ENV VERSION="${VERSION}" +ARG VERSION="latest" +ENV VERSION="$VERSION" +RUN echo "$VERSION" RUN apk add build-base &&\ make clean && make && \ - chmod 777 build/server && \ - echo "$VERSION" + chmod 777 build/server FROM alpine:latest RUN apk --no-cache add ca-certificates