From 252cd1fa2d25cf5b50907582dddb54afdacd1dcb Mon Sep 17 00:00:00 2001 From: Lakhan Samani Date: Tue, 18 Oct 2022 23:14:24 +0530 Subject: [PATCH] fix: make code_challenge optional --- server/handlers/authorize.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/server/handlers/authorize.go b/server/handlers/authorize.go index 0a8ee75..5ececd2 100644 --- a/server/handlers/authorize.go +++ b/server/handlers/authorize.go @@ -64,7 +64,7 @@ func AuthorizeHandler() gin.HandlerFunc { if err := validateAuthorizeRequest(responseType, responseMode, clientID, state, codeChallenge); err != nil { log.Debug("invalid authorization request: ", err) - gc.JSON(http.StatusBadRequest, gin.H{"error": err}) + gc.JSON(http.StatusBadRequest, gin.H{"error": err.Error()}) return } @@ -270,10 +270,6 @@ func validateAuthorizeRequest(responseType, responseMode, clientID, state, codeC return fmt.Errorf("invalid response mode %s. 'query', 'fragment', 'form_post' and 'web_message' are valid response_mode", responseMode) } - if responseType == constants.ResponseTypeCode && strings.TrimSpace(codeChallenge) == "" { - return fmt.Errorf("code_challenge is required for %s '%s'", responseType, constants.ResponseTypeCode) - } - if client, err := memorystore.Provider.GetStringStoreEnvVariable(constants.EnvKeyClientID); client != clientID || err != nil { return fmt.Errorf("invalid client_id %s", clientID) }