From 0d87d3d8893e3eded14f5190bebadae94f9dbd26 Mon Sep 17 00:00:00 2001
From: Untone <anton.rewin@gmail.com>
Date: Sun, 5 May 2024 21:38:59 +0300
Subject: [PATCH] unique-follows-debug

---
 resolvers/follower.py |  4 ++--
 services/cache.py     | 27 +++++++++++----------------
 2 files changed, 13 insertions(+), 18 deletions(-)

diff --git a/resolvers/follower.py b/resolvers/follower.py
index e54de25f..85115154 100644
--- a/resolvers/follower.py
+++ b/resolvers/follower.py
@@ -59,8 +59,8 @@ async def follow(_, info, what, slug):
             [author] = get_with_stat(select(Author).filter(Author.slug == slug))
             if author:
                 author_dict = author.dict()
-                author_id = author.id
-                follows_ids = [a.get("id") for a in follows]
+                author_id = int(author_dict.get('id', 0))
+                follows_ids = set(int(a.get('id')) for a in follows)
                 if author_id not in follows_ids:
                     await cache_author(author_dict)
                     await cache_author(follower_dict)
diff --git a/services/cache.py b/services/cache.py
index fd1f3bd8..169332ed 100644
--- a/services/cache.py
+++ b/services/cache.py
@@ -1,6 +1,5 @@
 import json
 
-
 from orm.topic import TopicFollower
 from services.encoders import CustomJSONEncoder
 from services.rediscache import redis
@@ -14,21 +13,20 @@ DEFAULT_FOLLOWS = {
 
 
 async def cache_author(author: dict):
+    author_id = author.get("id")
     payload = json.dumps(author, cls=CustomJSONEncoder)
     await redis.execute("SET", f'user:{author.get("user")}', payload)
-    await redis.execute("SET", f'author:{author.get("id")}', payload)
+    await redis.execute("SET", f'author:{author_id}', payload)
 
     # update stat all field for followers' caches in <authors> list
-    followers_str = await redis.execute("GET", f'author:{author.get("id")}:followers')
+    followers_str = await redis.execute("GET", f'author:{author_id}:followers')
     followers = []
     if isinstance(followers_str, str):
         followers = json.loads(followers_str)
     if isinstance(followers, list):
         for follower in followers:
             follower_follows_authors = []
-            follower_follows_authors_str = await redis.execute(
-                "GET", f'author:{author.get("id")}:follows-authors'
-            )
+            follower_follows_authors_str = await redis.execute("GET", f'author:{author_id}:follows-authors')
             if isinstance(follower_follows_authors_str, str):
                 follower_follows_authors = json.loads(follower_follows_authors_str)
                 c = 0
@@ -42,29 +40,26 @@ async def cache_author(author: dict):
                 follower_follows_authors.append(author)
 
     # update stat field for all authors' caches in <followers> list
-    follows_str = await redis.execute(
-        "GET", f'author:{author.get("id")}:follows-authors'
-    )
+    follows_str = await redis.execute("GET", f'author:{author_id}:follows-authors')
     follows_authors = []
     if isinstance(follows_str, str):
         follows_authors = json.loads(follows_str)
     if isinstance(follows_authors, list):
         for followed_author in follows_authors:
             followed_author_followers = []
-            followed_author_followers_str = await redis.execute(
-                "GET", f'author:{author.get("id")}:followers'
-            )
+            followed_author_followers_str = await redis.execute("GET", f'author:{author_id}:followers')
             if isinstance(followed_author_followers_str, str):
                 followed_author_followers = json.loads(followed_author_followers_str)
                 c = 0
                 for old_follower in followed_author_followers:
-                    if int(old_follower.get("id")) == int(author.get("id", 0)):
+                    old_follower_id = int(old_follower.get("id"))
+                    if old_follower_id == author_id:
                         followed_author_followers[c] = author
                         break  # exit the loop since we found and updated the author
                     c += 1
-            else:
-                # author not found in the list, so add the new author with the updated stat field
-                followed_author_followers.append(author)
+            # author not found in the list, so add the new author with the updated stat field
+            followed_author_followers.append(author)
+            await redis.execute("SET", f'author:{author_id}:followers', followed_author_followers)
 
 
 async def cache_follows(follower: dict, entity_type: str, entity: dict, is_insert=True):