biome-fixes

biome.json

@@ -27,6 +27,7 @@
         "useOptionalChain": "warn"
       },
       "a11y": {
+        "useHeadingContent": "off",
         "useKeyWithClickEvents": "off",
         "useKeyWithMouseEvents": "off",
         "useAnchorContent": "off",

src/components/Author/AuthorCard/AuthorCard.tsx

@@ -165,7 +165,9 @@ export const AuthorCard = (props: Props) => {
                             class={styles.subscribersItem}
                           />
                         )
-                      } else if ('title' in f) {
+                      }
+
+                      if ('title' in f) {
                         return (
                           <Userpic
                             size={'XS'}
@@ -175,6 +177,7 @@ export const AuthorCard = (props: Props) => {
                           />
                         )
                       }
+
                       return null
                     }}
                   </For>
@@ -196,7 +199,7 @@ export const AuthorCard = (props: Props) => {
                       class={styles.socialLink}
                       href={link.startsWith('http') ? link : `https://${link}`}
                       target="_blank"
-                      rel="nofollow noopener"
+                      rel="nofollow noopener noreferrer"
                     >
                       <span class={styles.authorSubscribeSocialLabel}>
                         {link.startsWith('http') ? link : `https://${link}`}

src/pages/article.page.tsx

@@ -16,7 +16,7 @@ export const ArticlePage = (props: PageProps) => {
   const shouts = props.article ? [props.article] : []
   const { page } = useRouter()
 
-  const slug = createMemo(() => page().params['slug'] as string)
+  const slug = createMemo(() => page().params.slug as string)
 
   const { articleEntities } = useArticlesStore({
     shouts,

src/pages/author.page.tsx

@@ -14,7 +14,7 @@ import { loadAuthor } from '../stores/zine/authors'
 export const AuthorPage = (props: PageProps) => {
   const { t } = useLocalize()
   const { page } = useRouter()
-  const slug = createMemo(() => page().params['slug'] as string)
+  const slug = createMemo(() => page().params.slug as string)
 
   const [isLoaded, setIsLoaded] = createSignal(
     Boolean(props.authorShouts) && Boolean(props.author) && props.author.slug === slug(),

src/pages/expo/expo.page.tsx

@@ -12,7 +12,7 @@ import { LayoutType } from '../types'
 export const ExpoPage = (props: PageProps) => {
   const { t } = useLocalize()
   const { page } = useRouter()
-  const getLayout = createMemo<LayoutType>(() => page().params['layout'] as LayoutType)
+  const getLayout = createMemo<LayoutType>(() => page().params.layout as LayoutType)
 
   const getTitle = () => {
     switch (getLayout()) {

src/pages/search.page.tsx

@@ -14,11 +14,11 @@ export const SearchPage = (props: PageProps) => {
   const [isLoaded, setIsLoaded] = createSignal(Boolean(props.searchResults))
   const { t } = useLocalize()
   const { page } = useRouter()
-  const q = createMemo(() => page().params['q'] as string)
+  const q = createMemo(() => page().params.q as string)
 
   createEffect(async () => {
     if (isLoaded()) return
-    else if (q() && window) {
+    if (q() && window) {
       const text = q() || window.location.href.split('/').pop()
       // TODO: pagination, load more
       await loadShoutsSearch({ text, limit: 50, offset: 0 })

src/pages/topic.page.tsx

@@ -12,7 +12,7 @@ import { loadTopic } from '../stores/zine/topics'
 
 export const TopicPage = (props: PageProps) => {
   const { page } = useRouter()
-  const slug = createMemo(() => page().params['slug'] as string)
+  const slug = createMemo(() => page().params.slug as string)
 
   const [isLoaded, setIsLoaded] = createSignal(
     Boolean(props.topicShouts) && Boolean(props.topic) && props.topic.slug === slug(),