From 702865b0e6d0e106f96d784a7ca917cdf7c75385 Mon Sep 17 00:00:00 2001 From: Untone Date: Wed, 1 May 2024 17:41:59 +0300 Subject: [PATCH] postmerge biomed --- src/components/App.tsx | 6 +----- src/components/Author/AuthorBadge/AuthorBadge.tsx | 2 +- src/components/Editor/AudioUploader/AudioUploader.tsx | 1 + src/components/Nav/AuthModal/LoginForm.tsx | 6 +++--- src/components/Nav/AuthModal/RegisterForm.tsx | 3 ++- src/components/Nav/HeaderAuth.tsx | 3 ++- .../NotificationView/NotificationGroup.tsx | 2 +- src/components/Topic/TopicBadge/TopicBadge.tsx | 2 +- src/components/Views/Home.tsx | 7 +++---- src/components/Views/PublishSettings/PublishSettings.tsx | 6 +++--- src/components/_shared/InviteMembers/InviteMembers.tsx | 1 - src/components/_shared/SolidSwiper/ImageSwiper.tsx | 4 ++-- src/context/following.tsx | 6 +++--- src/context/session.tsx | 1 + src/graphql/client/notifier.ts | 1 - src/stores/router.ts | 3 ++- src/stores/zine/authors.ts | 6 +++--- 17 files changed, 29 insertions(+), 31 deletions(-) diff --git a/src/components/App.tsx b/src/components/App.tsx index 726dd596..5a362864 100644 --- a/src/components/App.tsx +++ b/src/components/App.tsx @@ -40,15 +40,11 @@ import { InboxPage } from '../pages/inbox.page' import { HomePage } from '../pages/index.page' import { ProfileSecurityPage } from '../pages/profile/profileSecurity.page' import { ProfileSettingsPage } from '../pages/profile/profileSettings.page' -//TODO: ProfileSubscriptionsPage - garbage code? import { ProfileSubscriptionsPage } from '../pages/profile/profileSubscriptions.page' import { SearchPage } from '../pages/search.page' import { TopicPage } from '../pages/topic.page' import { ROUTES, useRouter } from '../stores/router' -import { MODALS, hideModal, showModal } from '../stores/ui' - -// TODO: lazy load -// const SomePage = lazy(() => import('./Pages/SomePage')) +import { MODALS, showModal } from '../stores/ui' const pagesMap: Record> = { author: AuthorPage, diff --git a/src/components/Author/AuthorBadge/AuthorBadge.tsx b/src/components/Author/AuthorBadge/AuthorBadge.tsx index b4f73b7c..c75648f5 100644 --- a/src/components/Author/AuthorBadge/AuthorBadge.tsx +++ b/src/components/Author/AuthorBadge/AuthorBadge.tsx @@ -1,6 +1,6 @@ import { openPage } from '@nanostores/router' import { clsx } from 'clsx' -import { Match, Show, Switch, createEffect, createMemo, createSignal, on } from 'solid-js' +import { Match, Show, Switch, createEffect, createMemo, createSignal } from 'solid-js' import { useFollowing } from '../../../context/following' import { useLocalize } from '../../../context/localize' diff --git a/src/components/Editor/AudioUploader/AudioUploader.tsx b/src/components/Editor/AudioUploader/AudioUploader.tsx index 59fa52bd..904e9a53 100644 --- a/src/components/Editor/AudioUploader/AudioUploader.tsx +++ b/src/components/Editor/AudioUploader/AudioUploader.tsx @@ -1,3 +1,4 @@ +// biome-ignore lint/style/useNodejsImportProtocol: import { Buffer } from 'buffer' import { clsx } from 'clsx' diff --git a/src/components/Nav/AuthModal/LoginForm.tsx b/src/components/Nav/AuthModal/LoginForm.tsx index 98c9ec05..83d89917 100644 --- a/src/components/Nav/AuthModal/LoginForm.tsx +++ b/src/components/Nav/AuthModal/LoginForm.tsx @@ -1,7 +1,7 @@ import type { AuthModalSearchParams } from './types' import { clsx } from 'clsx' -import { JSX, Show, createEffect, createSignal } from 'solid-js' +import { JSX, Show, createSignal } from 'solid-js' import { useLocalize } from '../../../context/localize' import { useSession } from '../../../context/session' @@ -31,8 +31,8 @@ export const LoginForm = () => { const [isSubmitting, setIsSubmitting] = createSignal(false) const [password, setPassword] = createSignal('') const [validationErrors, setValidationErrors] = createSignal({}) - - const [isLinkSent, setIsLinkSent] = createSignal(false) + // FIXME: use signal or remove + const [_isLinkSent, setIsLinkSent] = createSignal(false) const authFormRef: { current: HTMLFormElement } = { current: null } const { showSnackbar } = useSnackbar() const { signIn } = useSession() diff --git a/src/components/Nav/AuthModal/RegisterForm.tsx b/src/components/Nav/AuthModal/RegisterForm.tsx index b866a7d9..c58459aa 100644 --- a/src/components/Nav/AuthModal/RegisterForm.tsx +++ b/src/components/Nav/AuthModal/RegisterForm.tsx @@ -32,7 +32,8 @@ export const RegisterForm = () => { const { changeSearchParams } = useRouter() const { t } = useLocalize() const { signUp, isRegistered, resendVerifyEmail } = useSession() - const [submitError, setSubmitError] = createSignal('') + // FIXME: use submit error data or remove signal + const [_submitError, setSubmitError] = createSignal('') const [fullName, setFullName] = createSignal('') const [password, setPassword] = createSignal('') const [isSubmitting, setIsSubmitting] = createSignal(false) diff --git a/src/components/Nav/HeaderAuth.tsx b/src/components/Nav/HeaderAuth.tsx index 7f439b94..490323ad 100644 --- a/src/components/Nav/HeaderAuth.tsx +++ b/src/components/Nav/HeaderAuth.tsx @@ -59,7 +59,8 @@ export const HeaderAuth = (props: Props) => { toggleEditorPanel() } - const handleSaveButtonClick = () => { + // FIXME: remove the code if not needed here + const _handleSaveButtonClick = () => { saveShout(form) } diff --git a/src/components/NotificationsPanel/NotificationView/NotificationGroup.tsx b/src/components/NotificationsPanel/NotificationView/NotificationGroup.tsx index 3b3d8462..50b302d6 100644 --- a/src/components/NotificationsPanel/NotificationView/NotificationGroup.tsx +++ b/src/components/NotificationsPanel/NotificationView/NotificationGroup.tsx @@ -63,7 +63,7 @@ export const NotificationGroup = (props: NotificationGroupProps) => { return ( <> - {(n: Group, index) => ( + {(n: Group, _index) => ( <> {t(threadCaption(n.thread), { commentsCount: n.reactions.length })}{' '}
{ const { topAuthors } = useTopAuthorsStore() const { t } = useLocalize() - const [randomTopic, setRandomTopic] = createSignal(null) - const [randomTopicArticles, setRandomTopicArticles] = createSignal([]) + const [randomTopic, _setRandomTopic] = createSignal(null) + const [randomTopicArticles, _setRandomTopicArticles] = createSignal([]) onMount(async () => { loadTopArticles() diff --git a/src/components/Views/PublishSettings/PublishSettings.tsx b/src/components/Views/PublishSettings/PublishSettings.tsx index 47a2dee4..1e9f4a81 100644 --- a/src/components/Views/PublishSettings/PublishSettings.tsx +++ b/src/components/Views/PublishSettings/PublishSettings.tsx @@ -127,10 +127,10 @@ export const PublishSettings = (props: Props) => { } const handlePublishSubmit = () => { const shoutData = { ...props.form, ...settingsForm } - if (!shoutData?.mainTopic) { - showSnackbar({ body: t('Please, set the main topic first') }) - } else { + if (shoutData?.mainTopic) { publishShout(shoutData) + } else { + showSnackbar({ body: t('Please, set the main topic first') }) } } const handleSaveDraft = () => { diff --git a/src/components/_shared/InviteMembers/InviteMembers.tsx b/src/components/_shared/InviteMembers/InviteMembers.tsx index 3eca7cdc..42e5b711 100644 --- a/src/components/_shared/InviteMembers/InviteMembers.tsx +++ b/src/components/_shared/InviteMembers/InviteMembers.tsx @@ -10,7 +10,6 @@ import { useAuthorsStore } from '../../../stores/zine/authors' import { AuthorBadge } from '../../Author/AuthorBadge' import { Button } from '../Button' import { DropdownSelect } from '../DropdownSelect' -import { Loading } from '../Loading' import { InlineLoader } from '../../InlineLoader' import styles from './InviteMembers.module.scss' diff --git a/src/components/_shared/SolidSwiper/ImageSwiper.tsx b/src/components/_shared/SolidSwiper/ImageSwiper.tsx index 674ac701..fd5a1832 100644 --- a/src/components/_shared/SolidSwiper/ImageSwiper.tsx +++ b/src/components/_shared/SolidSwiper/ImageSwiper.tsx @@ -57,11 +57,11 @@ export const ImageSwiper = (props: Props) => { const { register } = await import('swiper/element/bundle') register() SwiperCore.use([Pagination, Navigation, Manipulation, HashNavigation]) - while (!mainSwipeRef.current || !mainSwipeRef.current.swiper) { + while (!mainSwipeRef.current?.swiper) { await new Promise((resolve) => setTimeout(resolve, 10)) // wait 10 ms } mainSwipeRef.current.swiper.on('slideChange', handleSlideChange) - const initialSlide = parseInt(searchParams().slide) - 1 + const initialSlide = Number.parseInt(searchParams().slide) - 1 if (initialSlide && !Number.isNaN(initialSlide) && initialSlide < props.images.length) { mainSwipeRef.current.swiper.slideTo(initialSlide, 0) } else { diff --git a/src/context/following.tsx b/src/context/following.tsx index 7859102b..3f42a6f2 100644 --- a/src/context/following.tsx +++ b/src/context/following.tsx @@ -1,4 +1,4 @@ -import { Accessor, JSX, createContext, createEffect, createMemo, createSignal, useContext } from 'solid-js' +import { Accessor, JSX, createContext, createEffect, createSignal, useContext } from 'solid-js' import { createStore } from 'solid-js/store' import { apiClient } from '../graphql/client/core' @@ -16,7 +16,7 @@ type SubscribeAction = { slug: string; type: 'subscribe' | 'unsubscribe' } interface FollowingContextType { loading: Accessor - followers: Accessor> + followers: Accessor subscriptions: AuthorFollowsResult setSubscriptions: (subscriptions: AuthorFollowsResult) => void setFollowing: (what: FollowingEntity, slug: string, value: boolean) => void @@ -41,7 +41,7 @@ const EMPTY_SUBSCRIPTIONS: AuthorFollowsResult = { export const FollowingProvider = (props: { children: JSX.Element }) => { const [loading, setLoading] = createSignal(false) - const [followers, setFollowers] = createSignal>([]) + const [followers, setFollowers] = createSignal([]) const [subscriptions, setSubscriptions] = createStore(EMPTY_SUBSCRIPTIONS) const { author, session } = useSession() diff --git a/src/context/session.tsx b/src/context/session.tsx index 3a189cc1..8fbd38e5 100644 --- a/src/context/session.tsx +++ b/src/context/session.tsx @@ -72,6 +72,7 @@ export type SessionContextType = { resendVerifyEmail: (params: ResendVerifyEmailInput) => Promise } +// biome-ignore lint/suspicious/noEmptyBlockStatements: const noop = () => {} const SessionContext = createContext() diff --git a/src/graphql/client/notifier.ts b/src/graphql/client/notifier.ts index 943f5218..6592849f 100644 --- a/src/graphql/client/notifier.ts +++ b/src/graphql/client/notifier.ts @@ -1,4 +1,3 @@ -import { createGraphQLClient } from '../createGraphQLClient' import markSeenMutation from '../mutation/notifier/mark-seen' import markSeenAfterMutation from '../mutation/notifier/mark-seen-after' import markThreadSeenMutation from '../mutation/notifier/mark-seen-thread' diff --git a/src/stores/router.ts b/src/stores/router.ts index 8be3b78c..46a5efd1 100644 --- a/src/stores/router.ts +++ b/src/stores/router.ts @@ -69,7 +69,8 @@ const checkOpenOnClient = (link: HTMLAnchorElement, event) => { ) } -const scrollToHash = (hash: string) => { +// TODO: use scrollToHash or remove +const _scrollToHash = (hash: string) => { let selector = hash if (/^#\d+/.test(selector)) { diff --git a/src/stores/zine/authors.ts b/src/stores/zine/authors.ts index 2253b84e..677af2a2 100644 --- a/src/stores/zine/authors.ts +++ b/src/stores/zine/authors.ts @@ -1,13 +1,13 @@ import { createLazyMemo } from '@solid-primitives/memo' -import { createEffect, createSignal } from 'solid-js' +import { createSignal } from 'solid-js' import { apiClient } from '../../graphql/client/core' import { Author, QueryLoad_Authors_ByArgs } from '../../graphql/schema/core.gen' export type AuthorsSortBy = 'shouts' | 'name' | 'followers' type SortedAuthorsSetter = (prev: Author[]) => Author[] - -const [sortAllBy, setSortAllBy] = createSignal('name') +// FIXME: use signal or remove +const [_sortAllBy, setSortAllBy] = createSignal('name') export const setAuthorsSort = (sortBy: AuthorsSortBy) => setSortAllBy(sortBy)