From 80a9a4c9a55c08f254c2a2fd2d84e7ef03a77cad Mon Sep 17 00:00:00 2001
From: Ilya Y <75578537+ilya-bkv@users.noreply.github.com>
Date: Mon, 13 Nov 2023 19:55:32 +0300
Subject: [PATCH 1/3] Update lightbox (#313)

update_lightbox
---
 src/components/Article/Article.module.scss        | 14 ++++----------
 src/components/Article/FullArticle.tsx            | 15 +++++++--------
 .../_shared/Lightbox/Lightbox.module.scss         |  6 ++++--
 src/components/_shared/Lightbox/Lightbox.tsx      |  8 +++++++-
 src/pages/profile/Settings.module.scss            |  8 ++++++--
 src/pages/profile/profileSettings.page.tsx        | 11 ++++++++++-
 6 files changed, 38 insertions(+), 24 deletions(-)

diff --git a/src/components/Article/Article.module.scss b/src/components/Article/Article.module.scss
index ed15b000..d2bc419d 100644
--- a/src/components/Article/Article.module.scss
+++ b/src/components/Article/Article.module.scss
@@ -23,22 +23,16 @@ img {
   }
 }
 
-.shoutCover {
-  background-size: cover;
-  height: 0;
-  padding-bottom: 56.2%;
+.articleContent {
+  img {
+    cursor: zoom-in;
+  }
 }
 
 .shoutBody {
   font-size: 1.6rem;
   line-height: 1.6;
 
-  img {
-    display: block;
-    margin-bottom: 0.5em;
-    cursor: zoom-in;
-  }
-
   blockquote,
   blockquote[data-type='punchline'] {
     clear: both;
diff --git a/src/components/Article/FullArticle.tsx b/src/components/Article/FullArticle.tsx
index 39586bb4..ed19fece 100644
--- a/src/components/Article/FullArticle.tsx
+++ b/src/components/Article/FullArticle.tsx
@@ -28,6 +28,7 @@ import { AuthorBadge } from '../Author/AuthorBadge'
 import { getImageUrl } from '../../utils/getImageUrl'
 import { FeedArticlePopup } from '../Feed/FeedArticlePopup'
 import { Lightbox } from '../_shared/Lightbox'
+import { Image } from '../_shared/Image'
 
 type Props = {
   article: Shout
@@ -252,7 +253,10 @@ export const FullArticle = (props: Props) => {
       <Title>{props.article.title}</Title>
       <div class="wide-container">
         <div class="row position-relative">
-          <article class="col-md-16 col-lg-14 col-xl-12 offset-md-5">
+          <article
+            class={clsx('col-md-16 col-lg-14 col-xl-12 offset-md-5', styles.articleContent)}
+            onClick={handleArticleBodyClick}
+          >
             {/*TODO: Check styles.shoutTopic*/}
             <Show when={props.article.layout !== 'music'}>
               <div class={styles.shoutHeader}>
@@ -282,12 +286,7 @@ export const FullArticle = (props: Props) => {
                     props.article.layout !== 'image'
                   }
                 >
-                  <div
-                    class={styles.shoutCover}
-                    style={{
-                      'background-image': `url('${getImageUrl(props.article.cover, { width: 1600 })}')`
-                    }}
-                  />
+                  <Image width={1600} alt={props.article.title} src={props.article.cover} />
                 </Show>
               </div>
             </Show>
@@ -328,7 +327,7 @@ export const FullArticle = (props: Props) => {
             </Show>
 
             <Show when={body()}>
-              <div id="shoutBody" class={styles.shoutBody} onClick={handleArticleBodyClick}>
+              <div id="shoutBody" class={styles.shoutBody}>
                 <Show when={!body().startsWith('<')} fallback={<div innerHTML={body()} />}>
                   <MD body={body()} />
                 </Show>
diff --git a/src/components/_shared/Lightbox/Lightbox.module.scss b/src/components/_shared/Lightbox/Lightbox.module.scss
index 834c8750..67075ab9 100644
--- a/src/components/_shared/Lightbox/Lightbox.module.scss
+++ b/src/components/_shared/Lightbox/Lightbox.module.scss
@@ -17,7 +17,8 @@
   }
 
   .close {
-    position: absolute;
+    position: fixed;
+    z-index: 1001;
     top: 20px;
     right: 40px;
     font-size: 30px;
@@ -29,12 +30,13 @@
 
   .zoomControls {
     display: flex;
-    position: absolute;
+    position: fixed;
     bottom: 16px;
     left: 50%;
     height: 24px;
     gap: 1rem;
     transform: translateX(-50%);
+    z-index: 1001;
 
     .control {
       border-radius: 50%;
diff --git a/src/components/_shared/Lightbox/Lightbox.tsx b/src/components/_shared/Lightbox/Lightbox.tsx
index a90bf219..a9dee711 100644
--- a/src/components/_shared/Lightbox/Lightbox.tsx
+++ b/src/components/_shared/Lightbox/Lightbox.tsx
@@ -1,7 +1,8 @@
 import { clsx } from 'clsx'
 import styles from './Lightbox.module.scss'
-import { createSignal } from 'solid-js'
+import { createSignal, onCleanup, onMount } from 'solid-js'
 import { Icon } from '../Icon'
+import { useEscKeyDownHandler } from '../../../utils/useEscKeyDownHandler'
 
 type Props = {
   class?: string
@@ -31,6 +32,8 @@ export const Lightbox = (props: Props) => {
     transition: 'transform 0.3s ease'
   })
 
+  useEscKeyDownHandler(closeLightbox)
+
   return (
     <div class={clsx(styles.Lightbox, props.class)} onClick={closeLightbox}>
       <span class={styles.close} onClick={closeLightbox}>
@@ -40,6 +43,9 @@ export const Lightbox = (props: Props) => {
         <button class={styles.control} onClick={(event) => zoomOut(event)}>
           <b>-</b>
         </button>
+        <button class={styles.control} onClick={() => setZoomLevel(1)}>
+          <b style={{ 'font-size': '10px' }}>1:1</b>
+        </button>
         <button class={styles.control} onClick={(event) => zoomIn(event)}>
           <b>+</b>
         </button>
diff --git a/src/pages/profile/Settings.module.scss b/src/pages/profile/Settings.module.scss
index 4553b827..50473218 100644
--- a/src/pages/profile/Settings.module.scss
+++ b/src/pages/profile/Settings.module.scss
@@ -234,9 +234,12 @@ h5 {
   border: 1px solid var(--black-100);
   cursor: pointer;
 
-  img {
-    width: 100%;
+  .userpicImage {
+    width: 180px;
+    height: 180px;
     border-radius: 50%;
+    background-position: center;
+    background-size: contain;
   }
 
   &.hasControls {
@@ -254,6 +257,7 @@ h5 {
   .control {
     width: 40px;
     height: 40px;
+    padding: 10px;
     border-radius: 50%;
     background: var(--background-color);
     border: 1px solid var(--black-100);
diff --git a/src/pages/profile/profileSettings.page.tsx b/src/pages/profile/profileSettings.page.tsx
index 991892c7..9eef5ad6 100644
--- a/src/pages/profile/profileSettings.page.tsx
+++ b/src/pages/profile/profileSettings.page.tsx
@@ -24,6 +24,7 @@ import { Icon } from '../../components/_shared/Icon'
 import { Popover } from '../../components/_shared/Popover'
 import { Image } from '../../components/_shared/Image'
 import { Loading } from '../../components/_shared/Loading'
+import { getImageUrl } from '../../utils/getImageUrl'
 
 export const ProfileSettingsPage = () => {
   const { t } = useLocalize()
@@ -150,7 +151,15 @@ export const ProfileSettingsPage = () => {
                               <Loading />
                             </Match>
                             <Match when={form.userpic}>
-                              <Image width={180} alt={form.name} src={form.userpic} />
+                              <div
+                                class={styles.userpicImage}
+                                style={{
+                                  'background-image': `url(${getImageUrl(form.userpic, {
+                                    width: 180,
+                                    height: 180
+                                  })})`
+                                }}
+                              />
                               <div class={styles.controls}>
                                 <Popover content={t('Delete userpic')}>
                                   {(triggerRef: (el) => void) => (

From 1a55a5bdb8877da8fbcb853e448dad699aba1584 Mon Sep 17 00:00:00 2001
From: kvakazyambra <kvakazyambra@gmail.com>
Date: Mon, 13 Nov 2023 21:28:21 +0300
Subject: [PATCH 2/3] Fixed error page style

---
 src/styles/FourOuFour.module.scss | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/styles/FourOuFour.module.scss b/src/styles/FourOuFour.module.scss
index 09a87b79..683b078b 100644
--- a/src/styles/FourOuFour.module.scss
+++ b/src/styles/FourOuFour.module.scss
@@ -1,12 +1,11 @@
 .errorPageWrapper {
   height: 100vh;
-  margin: -120px 0 -2em;
-  padding-top: 100px;
+  padding-top: 60px;
 }
 
 .errorPage {
   position: relative;
-  top: 35%;
+  top: 37%;
   transform: translateY(-50%);
 
   .image-link:hover {

From 252d78b35deb2916617fbdb3395bdcd54a002623 Mon Sep 17 00:00:00 2001
From: kvakazyambra <kvakazyambra@gmail.com>
Date: Mon, 13 Nov 2023 21:37:19 +0300
Subject: [PATCH 3/3] Fixed swiper slide height

---
 src/components/Feed/ArticleCard/ArticleCard.module.scss | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/Feed/ArticleCard/ArticleCard.module.scss b/src/components/Feed/ArticleCard/ArticleCard.module.scss
index 660df8ca..9ffcc750 100644
--- a/src/components/Feed/ArticleCard/ArticleCard.module.scss
+++ b/src/components/Feed/ArticleCard/ArticleCard.module.scss
@@ -403,7 +403,6 @@
 }
 
 .shoutCardWithCover {
-  aspect-ratio: 16/9;
   width: 100%;
 
   @include media-breakpoint-down(xl) {
@@ -413,6 +412,7 @@
   }
 
   swiper-slide & {
+    aspect-ratio: 16/9;
     margin-bottom: 0;
 
     @include media-breakpoint-down(lg) {